Draft
Conversation
dipenpradhan
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
=========================================
Coverage 44.05% 44.05%
Complexity 19 19
=========================================
Files 39 39
Lines 4444 4444
Branches 51 51
=========================================
Hits 1958 1958
Misses 2472 2472
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Snapshot diff report vs base branch: main
|
iamralpht
reviewed
Mar 11, 2026
| } | ||
|
|
||
| @Composable | ||
| private fun GetLiveUpdateCheckbox(state: Boolean, setState: (Boolean) -> Unit): ReplacementContent { |
Collaborator
There was a problem hiding this comment.
I know this is fitting in with the other names in the file, but I wonder how we ended up with GetXYZ for these instead of just XYZ
Collaborator
Author
There was a problem hiding this comment.
Changing this to add a new variant "Paused" to "Live/Offline" state display, and turn the display into a button instead.
iamralpht
reviewed
Mar 11, 2026
| // A successful call to fetchDocument (no exception) means we have a valid key. | ||
| // If this is the first success for this key, start the timer. | ||
| if (DesignSettings.firstSuccessTime == null) { | ||
| DesignSettings.firstSuccessTime = System.currentTimeMillis() |
Collaborator
There was a problem hiding this comment.
Can you use uptimeClock or something monotonic that won't get messed up by a time sync?
dipenpradhan
force-pushed
the
liveupdate-autopause
branch
from
b40f77e to
74aa3b9
Compare
… timeout and fetch interval This commit introduces several improvements to the LiveUpdate feature: - Replaced old Design Switcher Figma document with updated ID 1Ig75AsfrYc5DXdlOaCoCl containing Paused state for LiveMode. - Displayed Live Update fetch interval and pause timeout in the Design Switcher settings view, formatted as minutes. - Implemented a Figma API token timeout mechanism (Live Update Pause Millis, 30 minutes by default) that clears the token after expiration for security. - Made the Live Update fetch interval configurable (Live Update Fetch Millis, 5000ms by default). - Added click interactions on the #LiveMode node to manually toggle the Live Update pause state. - Updated ApiKeyService to allow enabling/disabling LiveUpdate, and changing the pause timeout and fetch interval via Intent. - Refactored DesignSettings to better manage the LiveUpdate status and respond to changes in the API key, the enabled state, the pause timeout, and the fetch interval. - Persistent storage for the LiveUpdate enabled state, timeout, and fetch interval using DataStore. - Documented new adb commands in the Live Update setup guide. - Added a log output to display the DesignCompose version on initialization. File-level changes: - ApiKeyService.kt: Added enableLiveUpdate, setAutopauseTimeout, and setLiveUpdateFetchMillis actions and handlers. - DesignSwitcher.kt: Updated Figma doc ID to 1Ig75AsfrYc5DXdlOaCoCl. Added 'Paused' to LiveMode enum. Integrated LiveUpdate pause toggle on #LiveMode node. - DocServer.kt: Implemented configurable token timeout and fetch interval logic, consolidating LiveUpdate status management. Exposed pauseUpdates as MutableState. - LiveUpdateSettingsRepository.kt: Added DataStore support for LiveUpdate enabled, pause timeout, and fetch interval preferences. - setup.md: Added adb command examples for the new advanced Live Update configurations. - build.gradle.kts: Enabled buildConfig and injected DESIGNCOMPOSE_VERSION.
dipenpradhan
force-pushed
the
liveupdate-autopause
branch
from
74aa3b9 to
5c6562b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LiveUpdate enhancements for #2282: