Include min and max values in the validation message in a number question if the values are in the extension

[chungwwei]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2757

Description
Show number must be between <INT_MIN> and <INT_MAX> when input is not an integer.
Use the max and min values in the extension if they are defined.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)
Screen_recording_20250101_225054.webm

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[FikriMilano]

Thanks for the PR!

[FikriMilano]

what happens when the minValue is bigger than the maxValue?
how about we throw an exception when that happens?

[chungwwei]

I added the exception. UI will crash when minValue > maxValue, like the slider and date widgets.

[FikriMilano]

Okay, but feel free to speak your thoughts on this, we could for example: show an error message to the user, instead of outright crashing the app. We're open for discussion.

What do you think?

[chungwwei]

Ig it's rare for a scenario like that to happen. Adheres to the rules, but with nonsensical values.

Alternatively, I view the minValue > maxValue a meaningless constraint on the UI, so it make sense to treat it as though the constraint doesn’t exist? We can set minAnswerValue and maxAnswerValue to null if when that happens.

Looks like the web app https://lhcforms.nlm.nih.gov/lhcforms ignored that scenario

[jingtang10]

Thanks for adding this. I'm ok with this PR.

Fikri's point is a good one - we do throw exceptions in other widgets when min value > max value. But I'm a bit concerned about the UI crasing... I wonder if we actually should remove that exception from the date and slider widgets.

But I'm open-minded in this case. I'll approve this PR - but pls resolve the exception question with fikri - and we can then merge this pr.

Thanks again for this - good work!

[FikriMilano]

I feel overriding the bind function is not necessary, updateValidationTextUI function is already called in the parent's bind (you can check it), so throwing the error in updateValidationTextUI should suffice.

What do you think?

[chungwwei]

I had it that way initially, but i thought placing the constraint check didn’t fit the intent of the function name updateValidationTextUI, so I moved it to bind. Like jingtang10 commented, it would be better to have it in the view model to remove redundancy

maybe have it in QuestionnaireItemViewHolder, I believe all the factories are extending QuestionnaireItemViewHolder

android-fhir/datacapture/src/main/java/com/google/android/fhir/datacapture/views/factories/QuestionnaireItemViewHolderFactory.kt

Lines 67 to 73 in ecf949a

	fun bind(questionnaireViewItem: QuestionnaireViewItem) {
	delegate.questionnaireViewItem = questionnaireViewItem
	delegate.bind(questionnaireViewItem)
	itemMediaView.bind(questionnaireViewItem.questionnaireItem)
	delegate.setReadOnly(questionnaireViewItem.questionnaireItem.readOnly)
	}
	}

[jingtang10]

if you have the max and min values on a different question type, e.g. slider? or date / date time?

if you put this logic in questionnaire view model this would be done for all widgets - instead of specific ui widgets.

[chungwwei]

hey @jingtang10, thanks for the pointer! I made some changes to the code based on your last comment. could you please take a look and let me know what you think