docs: fix typo in per-turn user simulator quality prompt#6305
Closed
anxkhn wants to merge 4 commits into
Closed
Conversation
Correct 'exsisting' to 'existing' in the Conversation History section of the with-persona evaluator prompt template. The sibling non-persona template already uses the correct spelling. This text is sent to the model at evaluation time.
rohityan
added
the
documentation
wyf7107
added
the
ready to pull
wyf7107
approved these changes
Jul 6, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Jul 6, 2026
Merge #6305 **Please ensure you have read the [contribution guide](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) before creating a pull request.** ### Link to Issue or Description of Change **2. Or, if no issue exists, describe the change:** **Problem:** The with-persona evaluator prompt template in `src/google/adk/evaluation/simulation/per_turn_user_simulator_quality_prompts.py` misspells "existing" as "exsisting" in its "Definition of Conversation History" section. This text is part of the prompt sent to the model at evaluation time, so it is model-facing rather than an internal comment. The sibling non-persona template in the same file already uses the correct spelling in the identical sentence, so the two templates are inconsistent. **Solution:** Correct the single word `exsisting` -> `existing` on that line. This makes the two templates consistent and fixes the model-facing text. No code path changes. ### Testing Plan This is a small typo fix in a prompt string, so no behavioral tests are added. The existing module test suite still passes and linting is clean: - `pre-commit run --files src/google/adk/evaluation/simulation/per_turn_user_simulator_quality_prompts.py` -> all Passed/Skipped. - `pytest tests/unittests/evaluation/simulation/test_per_turn_user_simulation_quality_prompts.py -q` -> 6 passed. **Unit Tests:** - [ ] I have added or updated unit tests for my change. (N/A: typo-only fix in a prompt string literal; the module's tests mock the templates and do not snapshot the prompt text.) - [x] All unit tests pass locally. ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [x] New and existing unit tests pass locally with my changes. COPYBARA_INTEGRATE_REVIEW=#6305 from anxkhn:docs/simulator-prompt-typo 34dc49f PiperOrigin-RevId: 943534249
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
The with-persona evaluator prompt template in
src/google/adk/evaluation/simulation/per_turn_user_simulator_quality_prompts.pymisspells "existing" as "exsisting" in its "Definition of Conversation History"
section. This text is part of the prompt sent to the model at evaluation time,
so it is model-facing rather than an internal comment. The sibling non-persona
template in the same file already uses the correct spelling in the identical
sentence, so the two templates are inconsistent.
Solution:
Correct the single word
exsisting->existingon that line. This makes thetwo templates consistent and fixes the model-facing text. No code path changes.
Testing Plan
This is a small typo fix in a prompt string, so no behavioral tests are added.
The existing module test suite still passes and linting is clean:
pre-commit run --files src/google/adk/evaluation/simulation/per_turn_user_simulator_quality_prompts.py-> all Passed/Skipped.pytest tests/unittests/evaluation/simulation/test_per_turn_user_simulation_quality_prompts.py -q-> 6 passed.Unit Tests:
Checklist