Skip to content

fix: support CitationMetadata#463

Merged
yarolegovich merged 2 commits intogoogle:mainfrom
nahapetyan-serob:serob/adk/metadata-support
Jan 8, 2026
Merged

fix: support CitationMetadata#463
yarolegovich merged 2 commits intogoogle:mainfrom
nahapetyan-serob:serob/adk/metadata-support

Conversation

@nahapetyan-serob
Copy link
Contributor

Added converters for CitationMetadata in ./server/adka2a/metadata.go and verified in test case.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nahapetyan-serob, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for CitationMetadata into the system's event processing. The primary goal is to ensure that citation information is correctly serialized and deserialized when events are transformed into and from A2A metadata. This enhancement allows for the consistent and accurate handling of citation data throughout the system, with corresponding test updates to confirm its functionality.

Highlights

  • CitationMetadata Support: Introduced comprehensive support for CitationMetadata within the system, allowing for its proper handling and transmission.
  • Conversion Logic Implementation: Added new conversion logic in server/adka2a/metadata.go to serialize CitationMetadata from session.Event to A2A metadata and deserialize it back, ensuring data integrity across conversions.
  • Test Case Verification: Updated an existing test case in agent/remoteagent/a2a_agent_test.go to include CitationMetadata in LLMResponse objects, validating the new functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for CitationMetadata by including converters in server/adka2a/metadata.go and updating the test cases in agent/remoteagent/a2a_agent_test.go. The changes are correct and follow the existing pattern for handling other metadata types. I've included a couple of suggestions to refactor the repetitive logic for handling metadata serialization and deserialization, which would improve code maintainability.

@yarolegovich yarolegovich self-requested a review January 7, 2026 11:35
@yarolegovich yarolegovich merged commit 46ea994 into google:main Jan 8, 2026
4 checks passed
davidli2010 pushed a commit to davidli2010/adk-go that referenced this pull request Feb 4, 2026
Added converters for CitationMetadata in ./server/adka2a/metadata.go and verified in test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants