Skip to content

Update linters #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethvargo merged 1 commit into from
Jul 18, 2025
Merged

Update linters #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actionlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
paths:
'.github/workflows/integration.yml':
ignore:
- 'property ".+" is not defined in object type'
16 changes: 13 additions & 3 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
with:
node-version: '20.x'
node-version-file: 'package.json'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand All @@ -47,7 +47,12 @@ jobs:
regional:${{ vars.REGIONAL_SECRET_NAME }}

- name: 'outputs'
run: echo '${{ steps.secrets.outputs.token }}${{ steps.secrets.outputs.password }}${{ steps.secrets.outputs.regional }}'
env:
TOKEN: '${{ steps.secrets.outputs.token }}'
PASSWORD: '${{ steps.secrets.outputs.password }}'
REGIONAL: '${{ steps.secrets.outputs.regional }}'
run: |-
echo '${TOKEN}${PASSWORD}${REGIONAL}'

- id: 'secrets-encoded'
name: 'secrets-encoded'
Expand All @@ -60,4 +65,9 @@ jobs:
regional:${{ vars.REGIONAL_SECRET_NAME }}

- name: 'outputs-encoded'
run: echo '${{ steps.secrets-encoded.outputs.token }}${{ steps.secrets-encoded.outputs.password }}${{ steps.secrets-encoded.outputs.regional }}'
env:
TOKEN: '${{ steps.secrets.outputs.token }}'
PASSWORD: '${{ steps.secrets.outputs.password }}'
REGIONAL: '${{ steps.secrets.outputs.regional }}'
run: |-
echo '${TOKEN}${PASSWORD}${REGIONAL}'
8 changes: 1 addition & 7 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,10 @@ jobs:

- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
with:
node-version: '20.x'
node-version-file: 'package.json'

- name: 'npm build'
run: 'npm ci && npm run build'

- name: 'npm lint'
# There's no need to run the linter for each operating system, since it
# will find the same thing 3x and clog up the PR review.
if: ${{ matrix.os == 'ubuntu-latest' }}
run: 'npm run lint'

- name: 'npm test'
run: 'npm run test'
2 changes: 2 additions & 0 deletions bin/runTests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ set -eEuo pipefail
FILES="$(node -e "process.stdout.write(require('node:fs').readdirSync('./', { recursive: true }).filter((e) => {return e.endsWith('.test.ts') && !e.startsWith('node_modules');}).sort().join(' '));")"

set -x

# shellcheck disable=SC2086
exec node --require ts-node/register --test-reporter spec --test ${FILES}
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
"format": "eslint . --fix",
"test": "bash ./bin/runTests.sh"
},
"engines": {
"node": "20.x",
"npm": "10.x"
},
"repository": {
"type": "git",
"url": "https://github.com/google-github-actions/get-secretmanager-secrets"
Expand Down
Loading