chore: Migrate gsutil usage to gcloud storage#311
chore: Migrate gsutil usage to gcloud storage#311bebechien merged 1 commit intogoogle-gemma:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @bebechien, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Google Cloud Storage interaction within the PaliGemma fine-tuning notebook by migrating all Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly migrates gsutil commands to their gcloud storage equivalents in the docs/paligemma/fine-tuning-paligemma.ipynb notebook. The changes are accurate and align with the best practice of using the more modern gcloud storage tool. The translation of command-line flags from gsutil to gcloud storage is also correct. While the changes in this PR are good, I noticed that another notebook, PaliGemma/[PaliGemma_2]Finetune_with_JAX.ipynb, still contains the old gsutil commands. To ensure consistency across the repository, you might want to consider updating that file as well in this or a follow-up PR.
google/generative-ai-docs#619