-
Notifications
You must be signed in to change notification settings - Fork 446
chore: Migrate gsutil usage to gcloud storage #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -424,14 +424,12 @@ | |||||||
| "TOKENIZER_PATH = \"./paligemma_tokenizer.model\"\n", | ||||||||
| "if not os.path.exists(TOKENIZER_PATH):\n", | ||||||||
| " print(\"Downloading the model tokenizer...\")\n", | ||||||||
| " !gsutil cp gs://big_vision/paligemma_tokenizer.model {TOKENIZER_PATH}\n", | ||||||||
| " print(f\"Tokenizer path: {TOKENIZER_PATH}\")\n", | ||||||||
| " !gcloud storage cp gs://big_vision/paligemma_tokenizer.model {TOKENIZER_PATH}\n", " print(f\"Tokenizer path: {TOKENIZER_PATH}\")\n", | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This automated change has broken the JSON formatting of the notebook by merging two lines into one. A newline and comma are missing between the two string elements in the
Suggested change
|
||||||||
| "\n", | ||||||||
| "DATA_DIR=\"./longcap100\"\n", | ||||||||
| "if not os.path.exists(DATA_DIR):\n", | ||||||||
| " print(\"Downloading the dataset...\")\n", | ||||||||
| " !gsutil -m -q cp -n -r gs://longcap100/ .\n", | ||||||||
| " print(f\"Data path: {DATA_DIR}\")" | ||||||||
| " !gcloud storage cp --no-clobber --recursive gs://longcap100/ .\n", " print(f\"Data path: {DATA_DIR}\")" | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||
| ] | ||||||||
| }, | ||||||||
| { | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated change has resulted in a malformed JSON structure for the notebook. The newline and comma separating two string elements in the
sourcearray have been removed, merging them into a single invalid line. This will prevent the notebook from being opened or parsed correctly.