fix python library dependencies#299
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @bebechien, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the setup instructions and dependency installations across several Jupyter notebooks. The changes ensure that all necessary Python libraries, such as Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses dependency issues across several notebooks, primarily by adding missing packages like kagglehub and updating the transformers installation method. The changes are logical and improve the setup process for these examples. I've added a couple of suggestions to enhance consistency and reproducibility by using upgrade flags and pinning a key dependency version.
| "outputs": [], | ||
| "source": [ | ||
| "!pip install -q gemma" | ||
| "!pip install -q gemma kagglehub" |
There was a problem hiding this comment.
For consistency with other notebooks in the repository (e.g., fine-tuning-paligemma.ipynb) and to ensure the latest compatible versions of packages are installed, it's good practice to use the -U (or --upgrade) flag.
| "!pip install -q gemma kagglehub" | |
| "!pip install -U -q gemma kagglehub" |
| "# Install Gemma release branch from Hugging Face\n", | ||
| "%pip install git+https://github.com/huggingface/transformers@v4.49.0-Gemma-3\n", | ||
| "# Install Transformers\n", | ||
| "%pip install transformers\n", |
There was a problem hiding this comment.
To ensure reproducibility and prevent potential breakages from future transformers releases, it's advisable to specify a minimum compatible version. Other notebooks in this repository use "transformers>=4.53.0", which would be a good addition here for consistency.
| "%pip install transformers\n", | |
| "%pip install \"transformers>=4.53.0\"\n" |
No description provided.