-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add examples/dp_sgd_transformer.py for DP training of a transformer.
#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add examples/dp_sgd_transformer.py for DP training of a transformer.
#90
Conversation
ryan112358
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like what you've done here, thanks for the PR. A few more comments then I think will be good to submit!
|
@ryan112358 Glad to hear that, a big thanks for speed running this PR by providing crucial reviews!! |
|
This has passed the first round of approval, now you mainly need to fix some formatting issues that came up in our internal checks. Please run flake8, pylint, and pytype on the add file and fix any issues encountered. Here is the list of problems that we see internally Line too long (84/80) [line-too-long]
|
RamSaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! I agree with Ryan that this example is a very valuable one!
I did my review and left few comments. Ryan or I might add two comments soon once I clarify some things for myself.
|
There are linter errors, could you sync your PR to head, then you will see them. We enabled linter checks for examples dir few minutes go :) |
…into example-dp-transformer
|
@RamSaw CI is running clean now just the comment on |
|
There are some complains from internal linter, I will figure it out too soon. I need to merge #133, then it should catch the formatting issues in your newly added file and give one command to apply the correct formatting. But for some reason it wants to format already existing, so I have to figure out what is wrong. |
Fixes:- #86
This pull request:-
jax_privacy/examplesto add a simple end-to-end and realistic example usage of the library.optax,clipped_grad&noise_addition.