Fix pandas 2.x compat: replace DataFrame.append with pd.concat#345
Open
atharvajoshi01 wants to merge 1 commit intogoldmansachs:masterfrom
Open
Fix pandas 2.x compat: replace DataFrame.append with pd.concat#345atharvajoshi01 wants to merge 1 commit intogoldmansachs:masterfrom
atharvajoshi01 wants to merge 1 commit intogoldmansachs:masterfrom
Conversation
…cat for pandas 2.x compat DataFrame.append and Series.append were removed in pandas 2.0. Replaced all occurrences in utility_processors.py, tree_entity.py, hedge.py, and results.py with pd.concat equivalents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #337.
DataFrame.appendandSeries.appendwere removed in pandas 2.0, causingAttributeErrorfor users on pandas >= 2.Replaced all 5 occurrences across 4 files with
pd.concat:gs_quant/analytics/processors/utility_processors.py(line 172)gs_quant/entities/tree_entity.py(lines 113, 116)gs_quant/markets/hedge.py(line 950)gs_quant/risk/results.py(line 129)List
.append()calls (which are valid) were left unchanged.Test plan
DataFrame.append/Series.appendin affected filespd.concatis a drop-in replacement with identical behavior for these use cases