Skip to content

[backtests]: Optimize SimulatedExecutionEngine and enhance ExecutionE…#314

Open
VinayakTiwari1103 wants to merge 1 commit intogoldmansachs:masterfrom
VinayakTiwari1103:engine-fix
Open

[backtests]: Optimize SimulatedExecutionEngine and enhance ExecutionE…#314
VinayakTiwari1103 wants to merge 1 commit intogoldmansachs:masterfrom
VinayakTiwari1103:engine-fix

Conversation

@VinayakTiwari1103
Copy link
Copy Markdown

…ngine structure

ExecutionEngine Module Enhancements

This PR enhances the ExecutionEngine module by:

  • Refactoring ExecutionEngine as an abstract base class (ABC).
  • Optimizing submit_order with bisect.insort for efficient order sorting.
  • Adding docstrings and type hints for improved readability and maintainability.
  • Introducing basic exception handling in the ping method.
  • Applying minor PEP8 cleanups.

These updates improve performance, robustness, and code clarity.

…ngine structure

Enhanced ExecutionEngine with ABC refactor, optimized order sorting, added docstrings/type hints, exception handling, and PEP8 cleanups for better performance and clarity.
@VinayakTiwari1103
Copy link
Copy Markdown
Author

Hi @rtsscy I have created the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant