Detect project version automatically#196
Open
charjr wants to merge 1 commit intogodotengine:masterfrom
Open
Conversation
charjr
force-pushed
the
get-godot-version
branch
5 times, most recently
from
fa7071e to
6f5ca2b
Compare
This has three advantages: - Saves maintainers updating the default value to latest each time. - Saves users updating their value. - Allows for different values per project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
gdscript-util--get-godot-project-versionReturns a string version that the current project is running under.
I downloaded several versions to check
config_version:config_version=3config_version=4config_version=5config_version=5If version is 3 or 4, return "3", otherwise read
config/featuresjust like the vc-code extension.Remove
gdscript-eglot-versionNo longer necessary, project version is detected automatically.
Removing it also saves the maintenance burden of having to update the default value on new releases.
Update README
Users don't need to concern themselves with manually setting it for 3.x so this section has been trimmed to what matters.