feat: encode and decode net/url.URL fields#860
Open
raeperd wants to merge 1 commit intogoccy:masterfrom
Open
Conversation
Add native support for encoding and decoding url.URL and *url.URL, following the existing time.Duration pattern.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
- Coverage 80.51% 80.49% -0.02%
==========================================
Files 22 22
Lines 6847 6881 +34
==========================================
+ Hits 5513 5539 +26
- Misses 913 917 +4
- Partials 421 425 +4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859
Purpose
Add native encode/decode support for
net/url.URLand*url.URL, following the existingtime.Durationpattern (#201).Changes
*url.URLincanDecodeByUnmarshaler, addcastToURLanddecodeURLusingurl.Parse()url.URLand*url.URLincanEncodeByMarshaler, addencodeURLusingurl.URL.String()Note on
url.Parsevsurl.ParseRequestURIThis implementation uses
url.Parse(), which is permissive (accepts relative paths like/api/v1). If you'd prefer the stricterurl.ParseRequestURI()(requires absolute URI with scheme), I'm happy to switch — just let me know.