Skip to content

fix(scanner): correct token offset after comment by accounting for comment character#857

Open
baa-ableton wants to merge 1 commit intogoccy:masterfrom
baa-ableton:fix/issue-856
Open

fix(scanner): correct token offset after comment by accounting for comment character#857
baa-ableton wants to merge 1 commit intogoccy:masterfrom
baa-ableton:fix/issue-856

Conversation

@baa-ableton
Copy link
Copy Markdown

@baa-ableton baa-ableton commented Mar 20, 2026

Before submitting your PR, please confirm the following.

Fixes: #856

Description: Normally, scanning '#' does not increment the offset, causing unexpected results.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.52%. Comparing base (d4021ff) to head (6f36596).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   80.51%   80.52%           
=======================================
  Files          22       22           
  Lines        6847     6849    +2     
=======================================
+ Hits         5513     5515    +2     
  Misses        913      913           
  Partials      421      421           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token.Position.Offset is incorrect when YAML contains comments

2 participants