fix(encoder): skip indentation for top-level sequences#855
Open
nervo wants to merge 1 commit intogoccy:masterfrom
Open
fix(encoder): skip indentation for top-level sequences#855nervo wants to merge 1 commit intogoccy:masterfrom
nervo wants to merge 1 commit intogoccy:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 80.51% 80.49% -0.03%
==========================================
Files 22 22
Lines 6847 6848 +1
==========================================
- Hits 5513 5512 -1
- Misses 913 914 +1
- Partials 421 422 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using encoder IndentSequence option, top level sequences are always indented, like i've already spotted in #291 (4 years ago, omg :) )
The playground is still available here https://go.dev/play/p/_mn80-HkPHK
Anyway, after digging into the code, i have found that indentation is handled differently for maps and sequences:
So i have just moved the sequence indentation logic at the just same level of maps, add some tests, and voila :)
Fix #291