Open
Conversation
Allow MarshalYAML (interface, error) function to return an ast.Node directly, which can then be immediately integrated into the ast.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 77.97% 77.98% +0.01%
==========================================
Files 22 22
Lines 8108 8113 +5
==========================================
+ Hits 6322 6327 +5
Misses 1370 1370
Partials 416 416 🚀 New features to boost your workflow:
|
Author
|
Is this project maintained? Is there anyone actually looking at PRs occasionally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm the following.
See #764
The current MarshalYAML implementation makes no allowance for functions that need to return carefully crafted ast nodes, and this unnecessarily limits their functionality.
By letting an InterfaceMarshaler return a Node and leaving it unmodified, custom marshalers get complete control over how their output is generated.