web/flow: reset stale authenticator selection between consecutive validate stages#20802
Open
Oluwatobi-Mustapha wants to merge 3 commits intogoauthentik:mainfrom
Open
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20802 +/- ##
==========================================
- Coverage 93.44% 93.40% -0.05%
==========================================
Files 992 992
Lines 55876 55876
==========================================
- Hits 52213 52189 -24
- Misses 3663 3687 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GirlBossRush
force-pushed
the
fix/mfa-autoselect-stage-scope-14941
branch
from
d3b5189 to
6782464
Compare
GirlBossRush
added
the
area:frontend
GirlBossRush
added
the
backport/version-2026.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14941
When the authenticator-validate stage component is reused across consecutive MFA stages, the previous selected challenge can persist into the next stage even if that challenge is no longer allowed.
This change resets the selected challenge when
challengeupdates and the previous selection is not present in the newdeviceChallengesset, then re-runs the existing auto-selection initialization path for the new challenge.Also adds unit coverage for stale-selection reset behavior.