fixup(scim): Group sync self-heal searches by SCIM displayName#20763
Open
josegomezr wants to merge 1 commit intogoauthentik:mainfrom
Open
fixup(scim): Group sync self-heal searches by SCIM displayName#20763josegomezr wants to merge 1 commit intogoauthentik:mainfrom
josegomezr wants to merge 1 commit intogoauthentik:mainfrom
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20763 +/- ##
==========================================
+ Coverage 93.16% 93.18% +0.02%
==========================================
Files 983 983
Lines 55475 55522 +47
==========================================
+ Hits 51683 51739 +56
+ Misses 3792 3783 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When groups are sent via SCIM and they already exists (as indicated by the SCIM server by a HTTP Status 409), the follow up GET request now uses the property mapped displayName instead of the authentik group model name.
4b1e145 to
1370bf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When groups are sent via SCIM and they already exists (as indicated by the SCIM server by a HTTP Status 409), the follow up GET request now uses the property mapped displayName instead of the authentik group model name.
Fixup from #19846
Checklist
ak test authentik/)make lint-fix)