Skip to content

fixup(scim): Group sync self-heal searches by SCIM displayName#20763

Open
josegomezr wants to merge 1 commit intogoauthentik:mainfrom
josegomezr:fixup_ak_scim_group_displayName
Open

fixup(scim): Group sync self-heal searches by SCIM displayName#20763
josegomezr wants to merge 1 commit intogoauthentik:mainfrom
josegomezr:fixup_ak_scim_group_displayName

Conversation

@josegomezr
Copy link
Contributor

Details

When groups are sent via SCIM and they already exists (as indicated by the SCIM server by a HTTP Status 409), the follow up GET request now uses the property mapped displayName instead of the authentik group model name.

Fixup from #19846

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

@josegomezr josegomezr requested a review from a team as a code owner March 6, 2026 13:23
@netlify
Copy link

netlify bot commented Mar 6, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 820cc40
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69aad54b1d8f1f0008c42de5
😎 Deploy Preview https://deploy-preview-20763--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.18%. Comparing base (ea3c56a) to head (1370bf0).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20763      +/-   ##
==========================================
+ Coverage   93.16%   93.18%   +0.02%     
==========================================
  Files         983      983              
  Lines       55475    55522      +47     
==========================================
+ Hits        51683    51739      +56     
+ Misses       3792     3783       -9     
Flag Coverage Δ
conformance 37.66% <0.00%> (-0.04%) ⬇️
e2e 42.64% <0.00%> (-0.03%) ⬇️
integration 22.37% <0.00%> (-0.07%) ⬇️
unit 91.56% <100.00%> (+0.01%) ⬆️
unit-migrate 91.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When groups are sent via SCIM and they already exists (as indicated by
the SCIM server by a HTTP Status 409), the follow up GET request now
uses the property mapped displayName instead of the authentik group
model name.
@josegomezr josegomezr force-pushed the fixup_ak_scim_group_displayName branch from 4b1e145 to 1370bf0 Compare March 6, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant