Skip to content

web/elements: Add preserve-order, no-search and no-status attributes to ak-dual-select#20749

Open
melizeche wants to merge 2 commits intomainfrom
akdualselect_improvements
Open

web/elements: Add preserve-order, no-search and no-status attributes to ak-dual-select#20749
melizeche wants to merge 2 commits intomainfrom
akdualselect_improvements

Conversation

@melizeche
Copy link
Member

Details

Add optional boolean attributes to ak-dual-select, ak-dual-select-provider, and ak-dual-select-dynamic-selected for preserving the insertion order instead of alphabetical (preserve-order), hiding the search bars (no-search), and item count status displays (no-status). All default to false, preserving existing behavior.

Rationale: When we have just a few items, we want a cleaner interface. Used in the WebAuthn authenticator stage form to simplify the device type hints selector. #20700

Originally:
Screenshot 2026-03-05 at 20-22-38 default-authenticator-webauthn-setup - Admin - authentik
After this PR:
Screenshot 2026-03-05 at 20-21-57 default-authenticator-webauthn-setup - Admin - authentik


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@melizeche melizeche requested a review from a team as a code owner March 5, 2026 23:44
@netlify
Copy link

netlify bot commented Mar 5, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 84e0730
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69aa1557d9fdf10008e8ba85
😎 Deploy Preview https://deploy-preview-20749--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 5, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 84e0730
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69aa155785124d0008ed8504
😎 Deploy Preview https://deploy-preview-20749--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-84e0730e3e6a2121661511f89f8fd44092a4102b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-84e0730e3e6a2121661511f89f8fd44092a4102b

Afterwards, run the upgrade commands from the latest release notes.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (ea3c56a) to head (84e0730).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20749      +/-   ##
==========================================
+ Coverage   93.16%   93.35%   +0.18%     
==========================================
  Files         983      983              
  Lines       55475    55475              
==========================================
+ Hits        51683    51787     +104     
+ Misses       3792     3688     -104     
Flag Coverage Δ
conformance 37.69% <ø> (+<0.01%) ⬆️
e2e 43.27% <ø> (+0.60%) ⬆️
integration 22.39% <ø> (-0.05%) ⬇️
unit 91.54% <ø> (+<0.01%) ⬆️
unit-migrate 91.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melizeche melizeche self-assigned this Mar 6, 2026
@melizeche melizeche added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Mar 6, 2026
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made a code improvement suggestion, but it's not a requirement or a request for a change.

<span class="pf-c-dual-list-selector__status-text"
>${selectedStatus}</span
>
</div>`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally the same code in both Available and Selected delta some configuration details. Maybe wrap these in a function with parameters?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants