web/elements: Add preserve-order, no-search and no-status attributes to ak-dual-select#20749
web/elements: Add preserve-order, no-search and no-status attributes to ak-dual-select#20749
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-84e0730e3e6a2121661511f89f8fd44092a4102b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-84e0730e3e6a2121661511f89f8fd44092a4102bAfterwards, run the upgrade commands from the latest release notes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20749 +/- ##
==========================================
+ Coverage 93.16% 93.35% +0.18%
==========================================
Files 983 983
Lines 55475 55475
==========================================
+ Hits 51683 51787 +104
+ Misses 3792 3688 -104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Looks good. I made a code improvement suggestion, but it's not a requirement or a request for a change.
| <span class="pf-c-dual-list-selector__status-text" | ||
| >${selectedStatus}</span | ||
| > | ||
| </div>`} |
There was a problem hiding this comment.
Literally the same code in both Available and Selected delta some configuration details. Maybe wrap these in a function with parameters?
Details
Add optional boolean attributes to
ak-dual-select,ak-dual-select-provider, andak-dual-select-dynamic-selectedfor preserving the insertion order instead of alphabetical (preserve-order), hiding the search bars (no-search), and item count status displays (no-status). All default tofalse, preserving existing behavior.Rationale: When we have just a few items, we want a cleaner interface. Used in the WebAuthn authenticator stage form to simplify the device type hints selector. #20700
Originally:


After this PR:
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)