[Feature] support PHP 8.5 first-class callable as default value for parameters and properties

[lisachenko]

Summary

• Proxy generation now preserves FCC default expressions (e.g. function foo($cb = strlen(...))) via raw AST nodes
• ValueGenerator — added fromExprNode() factory for pre-built AST Expr nodes that can't be represented as PHP scalars
• PropertyGenerator — added setDefaultExpressionNode() for Expr-based property defaults
• ParameterGenerator::fromReflection() — uses getNode()->default directly when parser-reflection is available, avoiding parser-reflection bugs where getDefaultValue() crashes (uninitialized typed property) or returns null for Closure defaults
• AbstractInterceptedPropertyGenerator::createBasePropertyGenerator() — same AST-first approach for intercepted properties

Why AST-first?

When parser-reflection is loaded, the raw AST default node is the authoritative source — it works uniformly for scalars, arrays, and FCC expressions. Calling getDefaultValue() can crash parser-reflection (ReflectionParameter::$defaultValue is uninitialized for FCC) or silently return null (ReflectionProperty::$defaultValue defaults to null). By reading getNode()->default directly, we bypass these issues entirely.

Test plan

• Full test suite: 2467 tests, 0 failures, 0 errors
• PHPStan level 10: 0 errors
• Array property interception test passes (validates AST path works for non-Closure const-expr defaults)
• PHP 8.4 safety: all new code paths gated by method_exists($param, 'getNode') (parser-reflection only)

🤖 Generated with Claude Code

[lisachenko]

Depends on goaop/parser-reflection#193

[Copilot]

Pull request overview

This PR updates the proxy-generation pipeline to preserve PHP 8.5+ first-class callable (FCC) default expressions for parameters and (promoted/intercepted) properties by carrying raw PhpParser AST Expr nodes through generation, instead of relying on Reflection*::getDefaultValue().

Changes:

• Add ValueGenerator::fromExprNode() to support defaults represented as pre-built AST expressions.
• Extend PropertyGenerator with setDefaultExpressionNode() and emit expression defaults directly when present.
• Update ParameterGenerator::fromReflection() and AbstractInterceptedPropertyGenerator::createBasePropertyGenerator() to prefer getNode()->default (parser-reflection) and throw a clear exception when a Closure default can’t be represented without AST access.
• Document the feature in CHANGELOG.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/Proxy/Part/AbstractInterceptedPropertyGenerator.php	Switch intercepted property default handling to prefer AST defaults when available.
src/Proxy/Generator/ValueGenerator.php	Add an AST-node-backed construction path for defaults that can’t be represented as scalars.
src/Proxy/Generator/PropertyGenerator.php	Allow property defaults to be set via a raw Expr node and emitted verbatim.
src/Proxy/Generator/ParameterGenerator.php	Prefer parameter AST defaults when available; add explicit failure for Closure defaults without AST access.
CHANGELOG.md	Add changelog entry documenting PHP 8.5+ FCC default value support.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.