fix: deduplicate HTTP methods in 405 Allow header#1040
Open
nathannewyen wants to merge 1 commit intogo-chi:masterfrom
Open
fix: deduplicate HTTP methods in 405 Allow header#1040nathannewyen wants to merge 1 commit intogo-chi:masterfrom
nathannewyen wants to merge 1 commit intogo-chi:masterfrom
Conversation
When multiple overlapping wildcard routes match the same path, the Allow header in 405 responses was containing duplicate HTTP methods (e.g., "POST POST POST POST" instead of just "POST"). This fix uses a map to track seen methods and only adds each method once to the Allow header. Fixes go-chi#996
9001d00 to
d95a851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allowheader of 405 responsesAllow: POST POST POST POSTReproduction
As described in the issue, when routes overlap due to wildcards:
A GET request to
/article/1-2-3previously returned:Now correctly returns:
Test plan
TestMethodNotAllowedDuplicateMethodstest caseFixes #996