Skip to content

Make EventBus Timeout Configurable#39

Merged
sbesson merged 1 commit intoglencoesoftware:masterfrom
kkoz:configure-timeout
Mar 5, 2026
Merged

Make EventBus Timeout Configurable#39
sbesson merged 1 commit intoglencoesoftware:masterfrom
kkoz:configure-timeout

Conversation

@kkoz
Copy link
Copy Markdown
Member

@kkoz kkoz commented Mar 3, 2026

Fixes #37
See github.com/glencoesoftware/omero-ms-image-region/pull/160

This PR is mostly for consistency with omero-ms-image-region in allowing the configuration of the EventBus send timeout in the config.yml file.

Testing

This one is trickier to test. The only ways I've succeeded are:

  1. Add a sleep line in the code
  2. Import a test image like 'test&sizeX=2304&sizeY=2304&sizeZ=12&sizeC=3&pixelType=uint16&sleepOpenBytes=500.fake'. Note the image ID. Then the very first call to webclient/render_birds_eye_view/<image id>/96 will trigger the sleep. Set your config accordingly to induce the timeout.

@kkoz kkoz requested a review from sbesson March 3, 2026 19:28
Copy link
Copy Markdown
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the sample synthetic file as glencoesoftware/omero-ms-image-region#160 (review) and the webclient/render_thumbnail/size/<size>/<id>/ endpoint.

When using a thumbnail size that has not already been generated, the render call exceeds the default 15s timeout (3 channels with a 5s delay per channel) and results in a 500 error. Re-running the same request returns immediately. Increasing the timeout to 20s via the configuration allows to request a thumbnail of different size without hitting the micro-service timeout.

@sbesson sbesson merged commit 964c71d into glencoesoftware:master Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make EventBus Timeout Configurable

2 participants