feat(mirax): add support for fluorescence z-stacks#318
Open
camlloyd wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #42 by adding MRXS fluorescence Z-stack support in
MiraxReader.It:
SizeZ > 1ExtFocusLevelfrom the physical Z axisPhysicalSizeZfromOFFSET_IN_MICROMETERSIndex.datValidation
The Z-stack behavior was validated with the sample from #42, and also with additional private MRXS Z-stack data.
I also regenerated a full OME-Zarr for the issue sample and checked it visually:
For regression coverage on non-Z MRXS files, I tested with:
BMP24sample, since BMP24 is not supported onmastereither)Focused
MiraxReaderunit tests cover the new parsing and the classic fallback behavior.I have not yet validated this branch on JPEG-XR-compressed MRXS data.
Notes
This change was developed with assistance from Codex using GPT-5.4.
One small follow-up left out of this PR to keep the diff focused:
indexDatainMiraxReader.initFile()still uses explicit close logic rather than try-with-resources.