fix: SLSA cache signing retry and Rekor conflicts#341
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
12fd8aa to
2dff5ab
Compare
WVerlaek
approved these changes
Jun 10, 2026
Co-authored-by: Codex <noreply@openai.com>
69cb91f to
45c49cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
leeway plumbing sign-cacheresilience for SLSA cache signing without weakening fail-closed behavior.INTERNAL_ERROR, timeouts, temporary network failures, and 429/5xx transport-style failures.--signing-retry-attemptsandLEEWAY_SIGNING_RETRY_ATTEMPTSwith conservative defaults and bounds.409 createLogEntryConflictonly when Leeway can fetch the existing entry and prove it matches the exact DSSE payload/certificate/signature-derived canonical Rekor body being published.Validation
PATH=/tmp/leeway-test-bin:/tmp/go/bin:$PATH go test ./cmd/... ./pkg/leeway/signing/... -count=1ok github.com/gitpod-io/leeway/cmd 0.137sok github.com/gitpod-io/leeway/pkg/leeway/signing 5.790sPATH=/tmp/leeway-test-bin:/tmp/go/bin:$PATH go test ./...PATH=/tmp/leeway-test-bin:/tmp/go/bin:$PATH go build -o /tmp/leeway-followup .PATH=/tmp/leeway-test-bin:/tmp/go/bin:$PATH golangci-lint run ./cmd/... ./pkg/leeway/signing/...cmd/build.go,cmd/exec.go,cmd/experimental-unmount.go,cmd/sbom-export.go, andcmd/init.go; no findings remain in touched signing/sign-cache code.CGO_ENABLED=1 go test -race ./cmd/... ./pkg/leeway/signing/... -count=1gccis not installed (cgo: C compiler "gcc" not found).Notes
The Rekor conflict recovery is implemented for Rekor v1, matching the observed
createLogEntryConflictfailure path. Rekor v2 remains on upstream Sigstore behavior because it has different duplicate semantics/API shape.