Handle git diffs that move a file without changing it #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing git diffs that move/rename a file without changing its content. It builds on PR #19 which added binary file handling, and fixes issue #20.
Changes:
- Added parsing support for git file rename operations with "similarity index 100%"
- Added
binaryfield toPatchstruct to distinguish binary file patches - Enhanced parser to handle git-specific header lines (diff command and index lines)
- Updated Display implementation to format rename-only and binary patches
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/parser.rs | Added diff_command and git_index_line parsers; modified patch() to handle file renames; added test for git file rename |
| src/ast.rs | Added binary field to Patch struct; updated Display to handle binary and rename-only patches |
| tests/regressions.rs | Updated test to include new binary field |
| tests/parse_samples.rs | Improved error messages with debug formatting |
| tests/wild-samples/*.patch | Added test samples for binary files and file renames |
| CHANGELOG.md | Documented fix for issue #20 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sourcefrog
force-pushed
the
only-file-moves
branch
2 times, most recently
from
1f22f1a to
048bc25
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sourcefrog
force-pushed
the
only-file-moves
branch
from
048bc25 to
1de718b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks after #19
Fixes #20