fix: reject duplicate bundle components - #4467
Open
marcelsafin wants to merge 2 commits into
Open
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Cross-kind duplicate-ID allowance needs regression coverage before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds bundle-manifest validation to reject duplicate component IDs within the same component kind.
Changes:
- Tracks
(kind, id)pairs during structural validation. - Adds regression coverage for duplicate extensions.
File summaries
| File | Description |
|---|---|
src/specify_cli/bundler/models/manifest.py |
Rejects duplicate component declarations. |
tests/contract/test_manifest_schema.py |
Tests same-kind duplicate rejection. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, well-scoped, and backed by targeted tests that cover both the rejection behavior and the cross-kind allowance contract.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
mnriem
added
the
triage-must-have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject duplicate component declarations within the same bundle component kind.
Previously, duplicate
(kind, id)entries passed structural validation. Duringinstallation, the first entry won and later declarations were silently skipped,
including conflicting version pins or preset options. Validation now reports
the duplicate before resolution or installation; identical IDs in different
component kinds remain valid.
Testing
uv run specify --helpuv sync && uv run pytestTargeted:
tests/contract/test_manifest_schema.py(39 passed).Full suite: 7,533 passed, 195 skipped. One existing PowerShell-launcher test
was omitted because
pwshis unavailable locally; it fails identically on theunchanged upstream commit.
AI Disclosure
GitHub Copilot (GPT-5.6 Sol) autonomously reproduced the bug, wrote the
regression test and implementation, and ran verification under
@marcelsafin's direction and review.