-
Notifications
You must be signed in to change notification settings - Fork 539
Report blocked gh-aw compiler versions during activation #59747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eaf8205
Initial plan
Copilot 034ebc1
Initial plan
Copilot a3b94e7
Report blocked compiler versions from activation
Copilot 1d5eb0e
Fix blocked compiler issue reporting type check
Copilot 4c1d242
Add ADR for blocked compiler version activation reporting
github-actions[bot] 2d79b05
Address review: preserve templatable value, revert unrelated lock dri…
Copilot 4afd478
Merge branch 'main' into copilot/fix-blocked-compiler-versions
pelikhan 0487226
Add on.report-blocked-version frontmatter flag to disable activation …
Copilot 86f6d51
Refactor blocked-version issue body to use markdown template
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot refactor text to template in actions/setup/md and use render file template to render.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 86f6d51: extracted the issue body into
actions/setup/md/blocked_compiler_version_issue.mdand refactoredbuildBlockedVersionIssueBodyto callrenderTemplateFromFile(getPromptPath(...), {...}), matching the pattern used inhandle_agent_failure.cjs.