Fix: replace deprecated force_all_finite with ensure_all_finite for sklearn>=1.6 - #720
Open
cngmid wants to merge 1 commit into
Open
Fix: replace deprecated force_all_finite with ensure_all_finite for sklearn>=1.6#720cngmid wants to merge 1 commit into
cngmid wants to merge 1 commit into
Conversation
…nd requirements.txt amended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issues/PRs
Fixes #719
This PR updates giotto‑tda’s use of
sklearn.utils.check_arrayto maintain compatibility with scikit‑learn ≥ 1.6, which removed theforce_all_finiteparameter. The new parameterensure_all_finiteis now used instead.Types of changes
force_all_finitewithensure_all_finiteDescription
Replaced all occurrences of
force_all_finitewithensure_all_finiteoccurring in 5 fileshomology\cubical.py,homology\simplicial.py,metaestimators\collection_transformer.py,test_validation.pyandutils\validation.py.Any other comments?
This is a minimal, safe compatibility patch.
No functional behavior of giotto‑tda is changed beyond restoring compatibility.
Checklist
flake8to check my Python changes.pytestto check this on Python tests.requirements.txtwithscikit-learn >= 1.6.