Skip to content

resolve cross-list duplicate citations in edge extraction#1673

Open
vvivekranjan wants to merge 1 commit into
getzep:mainfrom
vvivekranjan:fix/cross-list-duplicates
Open

resolve cross-list duplicate citations in edge extraction#1673
vvivekranjan wants to merge 1 commit into
getzep:mainfrom
vvivekranjan:fix/cross-list-duplicates

Conversation

@vvivekranjan

@vvivekranjan vvivekranjan commented Jul 22, 2026

Copy link
Copy Markdown

Summary

This PR fixes a bug in resolve_extracted_edge where valid duplicate edge citations identified by the LLM within existing_edges (invalidation candidates) were incorrectly discarded by the duplicate-range guard. The duplicate index validation has been expanded to support the entire continuous index space (up to max_valid_idx), allowing cross-list duplicates to be correctly mapped, resolved, attributed, and saved rather than leaked as new duplicate edges.

Type of Change

  • Bug fix
  • New feature
  • Performance improvement
  • Documentation/Tests

Objective

N/A - Bug fix

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Breaking Changes

  • This PR contains breaking changes

Checklist

  • Code follows project style guidelines (make lint passes)
  • Self-review completed
  • Documentation updated where necessary
  • No secrets or sensitive information committed

Related Issues

Closes #1672

@zep-cla-assistant

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. For privacy information, see our Privacy Notice. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: example@example.com

or

I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: example@example.com

Signature is valid for 6 months.


This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot.

@vvivekranjan

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: vvivekranjan20@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolve_extracted_edge's range guard discards a correctly-cited cross-list duplicate, leaking duplicate edges

1 participant