fix: Escape key only closes searchbar, does not reopen it#1271
Open
impsislegobatman wants to merge 1 commit intogetting-things-gnome:masterfrom
Open
fix: Escape key only closes searchbar, does not reopen it#1271impsislegobatman wants to merge 1 commit intogetting-things-gnome:masterfrom
impsislegobatman wants to merge 1 commit intogetting-things-gnome:masterfrom
Conversation
The Escape key was mapped to toggle_search which would reopen the searchbar after closing it. Added a close_search method that only dismisses the searchbar when it is active. Fixes getting-things-gnome#1243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1243
The Escape key was mapped to
toggle_search, which would reopen the searchbar after closing it with Ctrl+F.Changes
close_search()method that only dismisses the searchbar when it is currently active (no-op when already closed)close_searchinstead oftoggle_searchtoggle_searchto useclose_searchinternally