Fix issue #1000: Traceback catcher error popop GUI puts an extra set of #1267
Open
icysun wants to merge 1 commit intogetting-things-gnome:masterfrom
Open
Fix issue #1000: Traceback catcher error popop GUI puts an extra set of #1267icysun wants to merge 1 commit intogetting-things-gnome:masterfrom
icysun wants to merge 1 commit intogetting-things-gnome:masterfrom
Conversation
icysun
force-pushed
the
fix-issue-1000
branch
3 times, most recently
from
8bc97e3 to
99b5201
Compare
…I puts a (bug_fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been looking at issue #1000 and noticed this bug.
What I did
I implemented a fix for the issue described:
Testing
The fix has been tested locally:
Context
Issue description: For version 0.6, in PR #582 @Neui reimplemented the traceback catcher that was broken in #247. Seems like it has been put to good use by many users since then!
However, when I look at the reports f...
I believe this fix addresses the root cause. Let me know if you need any adjustments!
Thanks for the great project! 🙏