Add missing infobar for backends#1241
Open
diegogangl wants to merge 1 commit intogetting-things-gnome:masterfrom
Open
Add missing infobar for backends#1241diegogangl wants to merge 1 commit intogetting-things-gnome:masterfrom
diegogangl wants to merge 1 commit intogetting-things-gnome:masterfrom
Conversation
|
The infobar exception is fixed, now I have: Context: Global generic exception Traceback (most recent call last):
File "/home/eloi/dev/gtg/.local_build/install/lib/python3.13/site-packages/GTG/gtk/browser/main_window.py", line 1709, in remove_backend_infobar
self.vbox_toolbars.foreach(self.__remove_backend_infobar, backend_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Box' object has no attribute 'foreach' |
|
I tested this PR and can confirm it fixes the original This is because Here is the fix for all three occurrences:
# Before
self.vbox_toolbars.foreach(self.__remove_backend_infobar, backend_id)
# After
child = self.vbox_toolbars.get_first_child()
while child:
next_child = child.get_next_sibling()
self.__remove_backend_infobar(child, backend_id)
child = next_child
# Before
self.vbox_toolbars.foreach(self.__remove_backend_infobar, backend_id)
...
self.vbox_toolbars.add(infobar)
# After
child = self.vbox_toolbars.get_first_child()
while child:
next_child = child.get_next_sibling()
self.__remove_backend_infobar(child, backend_id)
child = next_child
...
self.vbox_toolbars.append(infobar)Tested on the current master with a live CalDAV backend — the Happy to open a follow-up PR if that's helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #998