Fix PHP Warning when accessing user_login property on boolean#25
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Fix PHP Warning when accessing user_login property on boolean#25devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: hidetaka@digitalcube.jp <hidetaka@digitalcube.jp>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP Warning when accessing user_login property on boolean
Issue
Fixes #24
This PR addresses a PHP Warning that occurs when attempting to read the property "user_login" on a boolean value within the Shifter WordPress MU plugin.
Root Cause
The
notify_logoutmethod inclass-shifter-api.phpdoesn't validate the result ofget_user_by('ID', $user_id)before attempting to access theuser_loginproperty. When an invalid user ID is passed,get_user_by()returnsfalse, causing a PHP warning.Solution
Added validation to check if
$useris a valid user object before accessing its properties. The method now gracefully handles cases whereget_user_by()returnsfalsewithout throwing PHP warnings.Testing
The fix has been tested by verifying that:
get_user_by()returnsfalsenotify_logoutmethodLink to Devin run
https://app.devin.ai/sessions/c8ccda563c184048acd7683871e96dab
Requested by: hidetaka@digitalcube.jp