ref(theme) remove theme.green100 to green400 #106145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
force-pushed
the
jb/theme/de-303
branch
from
0cf02f2 to
09003ce
Compare
TkDodo
reviewed
Jan 13, 2026
Comment on lines
57
to
60
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink400 : p.theme[`${themeColor}400`]}; | ||
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink400 : themeColor === 'green' ? p.theme.colors.green400 : p.theme[`${themeColor}400`]}; | ||
| } | ||
| .ansi-${ansiColor}-fg { | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink400 : p.theme[`${themeColor}400`]}; | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink400 : themeColor === 'green' ? p.theme.colors.green400 : p.theme[`${themeColor}400`]}; |
Collaborator
There was a problem hiding this comment.
same as in the other PR, green400 needs to become theme.colors.green500
JonasBa
commented
Jan 13, 2026
| ([ansiColor, themeColor]) => ` | ||
| .ansi-${ansiColor}-bg { | ||
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink400 : p.theme[`${themeColor}400`]}; | ||
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink500 : themeColor === 'green' ? p.theme.colors.green500 : p.theme[`${themeColor}400`]}; |
Member
Author
There was a problem hiding this comment.
I updated this as it was also wrongly updated in the previous PR
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/components/events/attachmentViewers/logFileViewer.tsx
Outdated
Show resolved
Hide resolved
TkDodo
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove theme.green100 to green400
Fix DE-303