ref(theme) remove yellow100-yellow400 #106144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/components/events/attachmentViewers/logFileViewer.tsx
Outdated
Show resolved
Hide resolved
TkDodo
reviewed
Jan 13, 2026
static/app/components/events/attachmentViewers/logFileViewer.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgets/bigNumberWidget/thresholdsIndicator.tsx
Show resolved
Hide resolved
TkDodo
approved these changes
Jan 14, 2026
TkDodo
reviewed
Jan 14, 2026
Comment on lines
-57
to
+63
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink400 : p.theme[`${themeColor}400`]}; | ||
| background-color: ${themeColor === 'pink' ? p.theme.colors.pink500 : themeColor === 'yellow' ? p.theme.colors.yellow500 : p.theme[`${themeColor}400`]}; | ||
| } | ||
| .ansi-${ansiColor}-fg { | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink400 : p.theme[`${themeColor}400`]}; | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink500 : themeColor === 'yellow' ? p.theme.colors.yellow500 : p.theme[`${themeColor}400`]}; | ||
| } | ||
| .ansi-bright-${ansiColor}-fg { | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink200 : p.theme[`${themeColor}200`]}; | ||
| color: ${themeColor === 'pink' ? p.theme.colors.pink200 : themeColor === 'yellow' ? p.theme.colors.yellow200 : p.theme[`${themeColor}200`]}; |
Collaborator
There was a problem hiding this comment.
since all the 400 colors will become 500 colors, in the end, this is just gonna be p.theme.colors[${themeColor}500]} without any ternaries.
that’s what I did for the red removal, I think we’re all gonna have conflicts on this 😅
Member
Author
There was a problem hiding this comment.
Yeah, we're going to have conflicts here, but they should be easy to resolve at least :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes yellow100 to yellow400 deprecated range
Fix DE-304