Use native setter for event level on desktop and consoles - #1577
Merged
Conversation
sentry-native 0.16.6 adds a per-event level setter, so the protocol "level" field no longer has to be written by hand.
tustanivsky
changed the title
tustanivsky
changed the title
tustanivsky
changed the title
tustanivsky
changed the title
tustanivsky
changed the title
jpnurmi
approved these changes
Sep 10, 2026
limbonaut
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the manual
"level"protocol field write inFGenericPlatformSentryEvent::SetLevelwith the dedicatedsentry_event_set_levelAPI added in sentry-native 0.16.6 via getsentry/sentry-native#2038.Previously the level was assigned by converting
ESentryLevelto its lowercased enum name and setting the"level"key on the event value directly. The new API does exactly that internally, so behavior is unchanged and the protocol detail now lives in sentry-native instead of the plugin. The conversion still goes through the existingSentryLevelToNativeconverter.Apple and Android are unaffected; they already set the level through per-event native APIs.
#skip-changelog