Skip to content

Conversation

@stayallive
Copy link
Collaborator

When tracking down some performance issues I noticed something odd with the Guzzle tracing middleware. I saw this:

image

That didn't look right to me, that second cache call is a custom Guzzle middleware that retrieves a access token from the cache and should be a child of the http.client span or be before that but it's after and seems to cause a "missing instrumentation" block even though everything is accounted for.

Turns out we never set the current span in the Guzzle middleware, this PR fixes that and now it looks like this:

image

Turns out this isn't the fix for the "missing instrumentation", but it is more correct now.

@stayallive stayallive self-assigned this Jan 25, 2025
@stayallive stayallive requested a review from cleptric January 25, 2025 14:08
@stayallive stayallive merged commit 87d0678 into master Jan 28, 2025
37 checks passed
@stayallive stayallive deleted the guzzle-set-span branch January 28, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants