Set the current span on the hub in Guzzle middleware #1801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracking down some performance issues I noticed something odd with the Guzzle tracing middleware. I saw this:
That didn't look right to me, that second cache call is a custom Guzzle middleware that retrieves a access token from the cache and should be a child of the
http.clientspan or be before that but it's after and seems to cause a "missing instrumentation" block even though everything is accounted for.Turns out we never set the current span in the Guzzle middleware, this PR fixes that and now it looks like this:
Turns out this isn't the fix for the "missing instrumentation", but it is more correct now.