-
-
Notifications
You must be signed in to change notification settings - Fork 465
feat(spotlight): Extract SpotlightIntegration to separate module #5064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
|
...-opentelemetry-core/src/main/java/io/sentry/opentelemetry/OtelInternalSpanDetectionUtil.java
Outdated
Show resolved
Hide resolved
sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java
Show resolved
Hide resolved
sentry-spotlight/src/test/java/io/sentry/util/SpotlightPlatformTestManipulator.kt
Show resolved
Hide resolved
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 276.52 ms | 370.46 ms | 93.93 ms |
| e59e22a | 374.68 ms | 442.14 ms | 67.46 ms |
| fcec2f2 | 357.47 ms | 447.32 ms | 89.85 ms |
| dba088c | 328.51 ms | 423.79 ms | 95.28 ms |
| fc5ccaf | 279.11 ms | 353.34 ms | 74.23 ms |
| b03edbb | 352.20 ms | 423.69 ms | 71.49 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| 2387c2c | 317.04 ms | 354.60 ms | 37.56 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
| d15471f | 302.62 ms | 353.84 ms | 51.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| e59e22a | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| b03edbb | 1.58 MiB | 2.13 MiB | 557.32 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 2387c2c | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
Previous results on branch: rz/fix/spotlight-insecure-url
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3de960 | 320.22 ms | 388.88 ms | 68.66 ms |
| 01f0c4b | 311.54 ms | 366.76 ms | 55.21 ms |
| 76153f6 | 307.83 ms | 352.64 ms | 44.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3de960 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| 01f0c4b | 1.58 MiB | 2.19 MiB | 619.16 KiB |
| 76153f6 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
c000776 to
f93665c
Compare
sentry-spotlight/src/main/java/io/sentry/spotlight/SpotlightIntegration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
📜 Description
Move SpotlightIntegration to a new sentry-spotlight module to allow
excluding it from release builds, preventing insecure HTTP URLs from
appearing in APKs and triggering security scanner warnings.
This change:
load SpotlightIntegration when the module is available
io.sentry.spotlight.enabled and io.sentry.spotlight.url
@InternalannotationBreaking Change: Users who enable Spotlight must now add the
io.sentry:sentry-spotlight dependency to their project.
💡 Motivation and Context
Fixes #3259
Fixes #3690
💚 How did you test it?
Existing tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
.craft.ymlto get auto-releases