-
-
Notifications
You must be signed in to change notification settings - Fork 465
feat: Allow setting native SDK name in manifest #5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f634d01 | 375.06 ms | 420.04 ms | 44.98 ms |
| d5a29b6 | 298.62 ms | 391.78 ms | 93.16 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
| bbc35bb | 324.88 ms | 425.73 ms | 100.85 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| d15471f | 369.38 ms | 459.08 ms | 89.70 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| fc5ccaf | 276.52 ms | 370.46 ms | 93.93 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| d15471f | 310.66 ms | 368.19 ms | 57.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| d5a29b6 | 1.58 MiB | 2.12 MiB | 549.37 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
Previous results on branch: feat/native-sdk-name-manifest
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ea83e7 | 363.80 ms | 430.24 ms | 66.44 ms |
| 1e749b4 | 326.17 ms | 409.79 ms | 83.62 ms |
| bf3d32c | 329.42 ms | 391.49 ms | 62.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ea83e7 | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| 1e749b4 | 1.58 MiB | 2.20 MiB | 633.77 KiB |
| bf3d32c | 1.58 MiB | 2.20 MiB | 635.34 KiB |
markushi
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add support for setting the native SDK name via AndroidManifest metadata.
This adds a new manifest key
io.sentry.ndk.sdk-namethat allows hybrid SDKs (like Unity) to configure the native SDK name for NDK crashes during build-time initialization.💡 Motivation and Context
When using the Sentry Unity SDK on Android, native C/C++ crashes captured by sentry-native are reported with SDK name
sentry.native.androidinstead ofsentry.native.android.unity.This happens because:
sentry-native-ndkAAR is compiled with the default SDK nameio.sentry.sdk.nameonly sets the Java SDK name, not the native SDK nameThe
nativeSdkNamecan be set at runtime viaSentryAndroidOptions.setNativeSdkName(), but for build-time initialization via manifest, there was no corresponding key.💚 How did you test it?
ManifestMetadataReader:applyMetadata reads nativeSdkName to options- verifies the value is read from manifestapplyMetadata reads nativeSdkName and keeps default- verifies null default is preserved📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
io.sentry.ndk.sdk-name=sentry.native.android.unityin AndroidManifest during build