-
-
Notifications
You must be signed in to change notification settings - Fork 377
refactor: Update SentryAttribute to use a generic array type #7324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7324 +/- ##
=============================================
+ Coverage 85.227% 85.229% +0.001%
=============================================
Files 475 475
Lines 28560 28557 -3
Branches 12410 12409 -1
=============================================
- Hits 24341 24339 -2
Misses 4174 4174
+ Partials 45 44 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9a34176 | 1227.24 ms | 1266.22 ms | 38.98 ms |
| 50e7b3e | 1221.54 ms | 1250.81 ms | 29.27 ms |
| 015d376 | 1187.58 ms | 1211.28 ms | 23.70 ms |
| a7d7fb6 | 1209.53 ms | 1235.91 ms | 26.38 ms |
| 5a4353f | 1208.10 ms | 1240.50 ms | 32.40 ms |
| 99e17bb | 1218.50 ms | 1243.91 ms | 25.41 ms |
| 41b4993 | 1215.15 ms | 1248.14 ms | 32.99 ms |
| 1d0feed | 1213.31 ms | 1247.44 ms | 34.14 ms |
| 7714225 | 1213.24 ms | 1252.28 ms | 39.04 ms |
| 58a9225 | 1211.40 ms | 1238.88 ms | 27.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9a34176 | 24.14 KiB | 1.10 MiB | 1.07 MiB |
| 50e7b3e | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 015d376 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| a7d7fb6 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 5a4353f | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 99e17bb | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 41b4993 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 1d0feed | 24.14 KiB | 1.05 MiB | 1.03 MiB |
| 7714225 | 24.14 KiB | 1.07 MiB | 1.05 MiB |
| 58a9225 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
📜 Description
Replaces the array attributes type with a generic
array💡 Motivation and Context
After reviewing the developer docs, I found out that array attributes now expect
arrayas the type.Related:
arrayattribute to telemetry attributes sentry-docs#15994💚 How did you test it?
For now only unit tests, array attributes are not visible in Sentry UI so only unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7341