Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Jan 30, 2026

📜 Description

Replaces the array attributes type with a generic array

💡 Motivation and Context

After reviewing the developer docs, I found out that array attributes now expect array as the type.
Related:

💚 How did you test it?

For now only unit tests, array attributes are not visible in Sentry UI so only unit tests

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7341

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • In_foreground and is_active app context by philipphofmann in #7188

Internal Changes 🔧

  • Update SentryAttribute to use a generic array type by itaybre in #7324
  • ObjC Integration cleanup by itaybre in #7320

🤖 This preview updates automatically when you update the PR.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.229%. Comparing base (a1ddc79) to head (e4c295a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/Protocol/SentryAttribute.swift 77.777% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7324       +/-   ##
=============================================
+ Coverage   85.227%   85.229%   +0.001%     
=============================================
  Files          475       475               
  Lines        28560     28557        -3     
  Branches     12410     12409        -1     
=============================================
- Hits         24341     24339        -2     
  Misses        4174      4174               
+ Partials        45        44        -1     
Files with missing lines Coverage Δ
...ources/Swift/Protocol/SentryAttributeContent.swift 98.913% <100.000%> (ø)
Sources/Swift/Protocol/SentryAttribute.swift 94.326% <77.777%> (-0.119%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ddc79...e4c295a. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Jan 30, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.00 ms 1245.76 ms 37.76 ms
Size 24.14 KiB 1.10 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a34176 1227.24 ms 1266.22 ms 38.98 ms
50e7b3e 1221.54 ms 1250.81 ms 29.27 ms
015d376 1187.58 ms 1211.28 ms 23.70 ms
a7d7fb6 1209.53 ms 1235.91 ms 26.38 ms
5a4353f 1208.10 ms 1240.50 ms 32.40 ms
99e17bb 1218.50 ms 1243.91 ms 25.41 ms
41b4993 1215.15 ms 1248.14 ms 32.99 ms
1d0feed 1213.31 ms 1247.44 ms 34.14 ms
7714225 1213.24 ms 1252.28 ms 39.04 ms
58a9225 1211.40 ms 1238.88 ms 27.48 ms

App size

Revision Plain With Sentry Diff
9a34176 24.14 KiB 1.10 MiB 1.07 MiB
50e7b3e 24.14 KiB 1.04 MiB 1.02 MiB
015d376 24.14 KiB 1.09 MiB 1.07 MiB
a7d7fb6 24.14 KiB 1.06 MiB 1.04 MiB
5a4353f 24.14 KiB 1.07 MiB 1.04 MiB
99e17bb 24.14 KiB 1.09 MiB 1.06 MiB
41b4993 24.14 KiB 1.06 MiB 1.04 MiB
1d0feed 24.14 KiB 1.05 MiB 1.03 MiB
7714225 24.14 KiB 1.07 MiB 1.05 MiB
58a9225 24.14 KiB 1.06 MiB 1.04 MiB

Previous results on branch: itay/update_attributes_type

Startup times

Revision Plain With Sentry Diff
ce8685b 1219.83 ms 1253.89 ms 34.06 ms

App size

Revision Plain With Sentry Diff
ce8685b 24.14 KiB 1.10 MiB 1.07 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Update SentryAttribute to use a generic array type

2 participants