feat: add sample_rand / fix sample_rate in baggage#4751
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4751 +/- ##
=============================================
+ Coverage 91.101% 91.390% +0.288%
=============================================
Files 626 627 +1
Lines 72769 74419 +1650
Branches 25866 26755 +889
=============================================
+ Hits 66294 68012 +1718
+ Misses 6382 6310 -72
- Partials 93 97 +4
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eea25a8 | 1240.54 ms | 1262.69 ms | 22.15 ms |
| ed64658 | 1225.06 ms | 1247.73 ms | 22.67 ms |
| 2d2068d | 1238.02 ms | 1249.90 ms | 11.88 ms |
| 489fbb8 | 1238.67 ms | 1265.66 ms | 26.99 ms |
| 4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
| 9ce54cc | 1217.79 ms | 1239.42 ms | 21.63 ms |
| ce54c6a | 1237.02 ms | 1241.02 ms | 4.00 ms |
| 522f8da | 1230.19 ms | 1252.31 ms | 22.12 ms |
| f8833c4 | 1230.00 ms | 1245.27 ms | 15.27 ms |
| a90f228 | 1226.37 ms | 1248.63 ms | 22.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eea25a8 | 22.31 KiB | 771.26 KiB | 748.94 KiB |
| ed64658 | 22.30 KiB | 749.84 KiB | 727.54 KiB |
| 2d2068d | 21.58 KiB | 729.47 KiB | 707.89 KiB |
| 489fbb8 | 21.90 KiB | 730.10 KiB | 708.20 KiB |
| 4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
| 9ce54cc | 21.58 KiB | 573.72 KiB | 552.13 KiB |
| ce54c6a | 21.58 KiB | 418.60 KiB | 397.02 KiB |
| 522f8da | 21.90 KiB | 726.18 KiB | 704.28 KiB |
| f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
| a90f228 | 21.90 KiB | 724.12 KiB | 702.22 KiB |
Previous results on branch: philprime/issue-4687-sampling-seed-propagation
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab1ebcb | 1214.52 ms | 1235.14 ms | 20.62 ms |
| f5ee173 | 1225.88 ms | 1240.40 ms | 14.52 ms |
| 5400890 | 1230.16 ms | 1243.23 ms | 13.07 ms |
| 544ce99 | 1216.27 ms | 1227.33 ms | 11.06 ms |
| a618a92 | 1221.79 ms | 1242.41 ms | 20.62 ms |
| abfb8ff | 1226.31 ms | 1245.65 ms | 19.35 ms |
| 63bb06c | 1216.49 ms | 1237.31 ms | 20.82 ms |
| ca8ee23 | 1227.45 ms | 1247.34 ms | 19.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab1ebcb | 22.31 KiB | 777.76 KiB | 755.45 KiB |
| f5ee173 | 22.31 KiB | 780.37 KiB | 758.05 KiB |
| 5400890 | 22.31 KiB | 776.94 KiB | 754.62 KiB |
| 544ce99 | 22.31 KiB | 777.60 KiB | 755.29 KiB |
| a618a92 | 22.31 KiB | 777.65 KiB | 755.34 KiB |
| abfb8ff | 22.31 KiB | 776.94 KiB | 754.62 KiB |
| 63bb06c | 22.31 KiB | 777.76 KiB | 755.45 KiB |
| ca8ee23 | 22.31 KiB | 775.60 KiB | 753.29 KiB |
a0f0b4f to
07f9ad4
Compare
07f9ad4 to
541c625
Compare
|
Back to draft because I noticed missing test cases |
brustolin
left a comment
There was a problem hiding this comment.
I do have one comment that I think would short this PR a lot.
philipphofmann
left a comment
There was a problem hiding this comment.
I will give this a full review once we remove the span changes, as this will significantly reduce the scope of the PR.
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the extra tests
…sampling-seed-propagation
📜 Description
sample_randto the baggagesample_ratenot added to baggage💡 Motivation and Context
See #4687
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps