Bootstrap textarea does not contain placeholder. Fixes #6#14
Open
fmms wants to merge 1 commit intogetgrav:developfrom
Open
Bootstrap textarea does not contain placeholder. Fixes #6#14fmms wants to merge 1 commit intogetgrav:developfrom
fmms wants to merge 1 commit intogetgrav:developfrom
Conversation
The placeholder is missing. adjust to adjust to the base at https://github.com/getgrav/grav-plugin-form/blob/develop/templates/forms/fields/textarea/textarea.html.twig However we use rows=10 as default to be backwards comptible
Contributor
|
Drop |
Contributor
|
This is the only theme that overrides the Form input fields and actually it's a bad thing, it should not re-implement them completely, just add the custom styling/classes/markup it needs. Will re-visit this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholder is missing. adjust to adjust to the base at
https://github.com/getgrav/grav-plugin-form/blob/develop/templates/forms/fields/textarea/textarea.html.twig
However we use rows=10 as default to be backwards comptible