Skip to content

[aikido] fix: upgrade react native community cli for with-crossmint repo#31

Merged
yosriady merged 1 commit into
mainfrom
keilok/aikido-critical-dependency-issue
May 25, 2026
Merged

[aikido] fix: upgrade react native community cli for with-crossmint repo#31
yosriady merged 1 commit into
mainfrom
keilok/aikido-critical-dependency-issue

Conversation

@keiloktql
Copy link
Copy Markdown
Member

@keiloktql keiloktql commented May 22, 2026

Summary

Patches CVE-2025-11953 (CVSS Critical) in with-crossmint by forcing @react-native-community/cli and @react-native-community/cli-server-api from 13.6.4 to 17.0.1 via pnpm overrides. The vulnerable packages are deep transitive deps — pulled in through @crossmint/client-sdk-react-ui@dynamic-labs@turnkey/cryptoreact-native@0.74.0 — so they cannot be upgraded directly; a range override is the correct fix. The 17.0.1 upgrade also pulls in fresher browserslist ecosystem data packages (baseline-browser-mapping, electron-to-chromium, etc.) that release daily and would otherwise trip the minimumReleaseAge gate, so those are added to minimumReleaseAgeExclude.

Key Changes

with-crossmint/pnpm-workspace.yaml:

  • Added overrides @react-native-community/cli@>=1.0.0 <17.0.1 and @react-native-community/cli-server-api@>=1.0.0 <17.0.117.0.1 (CVE-2025-11953: Metro dev server OS command injection)
  • Added baseline-browser-mapping, caniuse-lite, electron-to-chromium, node-releases to minimumReleaseAgeExclude — these are daily-updating browser-compat data packages in the browserslist ecosystem, not executable code, so excluding them from the age gate is safe
  • Added @formo/analytics to minimumReleaseAgeExclude (was referenced in a comment but missing from the actual config)

with-crossmint/pnpm-lock.yaml:

  • @react-native-community/cli@13.6.4 and @react-native-community/cli-server-api@13.6.4 replaced by 17.0.1 throughout

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@keiloktql keiloktql requested a review from yosriady May 22, 2026 08:07
@keiloktql keiloktql self-assigned this May 22, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces package overrides for @react-native-community/cli and @react-native-community/cli-server-api to version 17.0.1 and adds a minimumReleaseAgeExclude configuration to the workspace. A high-severity issue was identified regarding the CLI upgrade; version 17.0.1 is incompatible with the current react-native@0.74.0 dependency. To resolve CVE-2025-11953 without breaking the build, it is suggested to use version 13.6.6 instead.

Comment on lines +18 to +19
'@react-native-community/cli@>=1.0.0 <17.0.1': 17.0.1
'@react-native-community/cli-server-api@>=1.0.0 <17.0.1': 17.0.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @react-native-community/cli to 17.0.1 while the project is on react-native@0.74.0 will likely cause significant compatibility issues and build failures, as CLI 17 is intended for much newer versions of React Native (0.78+). Additionally, this creates a version mismatch with other platform packages like @react-native-community/cli-platform-android which remain at 13.6.4 in the lockfile.

To fix CVE-2025-11953 while maintaining compatibility with React Native 0.74.0, you should upgrade to the patched version in the 13.x branch, which is 13.6.6.

  '@react-native-community/cli@>=1.0.0 <13.6.6': 13.6.6
  '@react-native-community/cli-server-api@>=1.0.0 <13.6.6': 13.6.6

@yosriady yosriady merged commit 88d1fe0 into main May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants