Skip to content

Scheduler: No background mode if there is just one merge job#1529

Open
Flowdalic wants to merge 1 commit intogentoo:masterfrom
Flowdalic:max-jobs-one-if-possible
Open

Scheduler: No background mode if there is just one merge job#1529
Flowdalic wants to merge 1 commit intogentoo:masterfrom
Flowdalic:max-jobs-one-if-possible

Conversation

@Flowdalic
Copy link
Member

No description provided.

@thesamesam
Copy link
Member

thesamesam commented Dec 18, 2025

This will fix https://bugs.gentoo.org/339579. I am unconvinced that passing --jobs N is a reasonable way as suggested in the bug to avoid getting output, though. But let's discuss it there.

I, too, have found the current behaviour unfortunate.

@Flowdalic
Copy link
Member Author

This will fix https://bugs.gentoo.org/339579.

As always, I'm impressed by your existing-bug finding skillz. :)

I am unconvinced that passing --jobs N is a reasonable way as suggested in the bug to avoid getting output, though. But let's discuss it there.

With this PR one can use --quiet or --quiet-build to avoid getting build output.

I, too, have found the current behaviour unfortunate.

Right, the current behavior is very unfortunate.

@Flowdalic Flowdalic force-pushed the max-jobs-one-if-possible branch from c0dfc47 to e12f6ac Compare December 18, 2025 13:18
gentoo-bot pushed a commit that referenced this pull request Dec 19, 2025
Improve the readability of _background_mode() by introducing the local
variable 'parallel_jobs'.

Signed-off-by: Florian Schmaus <flow@gentoo.org>
Part-of: #1529
Signed-off-by: Sam James <sam@gentoo.org>
@Flowdalic Flowdalic force-pushed the max-jobs-one-if-possible branch from e12f6ac to 5aae622 Compare December 20, 2025 15:18
Hiding the build/test output if there is just one merge job results in
a bad package testing experience (for users who have --jobs enabled by
default). Therefore, do not go in background mode if there is just one
merge job and --quiet was not requested.

Closes: https://bugs.gentoo.org/339579
Signed-off-by: Florian Schmaus <flow@gentoo.org>
@Flowdalic Flowdalic force-pushed the max-jobs-one-if-possible branch from 5aae622 to 5535ca2 Compare December 21, 2025 09:31
@Flowdalic Flowdalic requested review from mgorny and zmedico December 21, 2025 09:40
Copy link
Member

@zmedico zmedico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants