Scheduler: No background mode if there is just one merge job#1529
Open
Flowdalic wants to merge 1 commit intogentoo:masterfrom
Open
Scheduler: No background mode if there is just one merge job#1529Flowdalic wants to merge 1 commit intogentoo:masterfrom
Flowdalic wants to merge 1 commit intogentoo:masterfrom
Conversation
Member
|
This will fix https://bugs.gentoo.org/339579. I am unconvinced that passing I, too, have found the current behaviour unfortunate. |
Member
Author
As always, I'm impressed by your existing-bug finding skillz. :)
With this PR one can use
Right, the current behavior is very unfortunate. |
c0dfc47 to
e12f6ac
Compare
gentoo-bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Improve the readability of _background_mode() by introducing the local variable 'parallel_jobs'. Signed-off-by: Florian Schmaus <flow@gentoo.org> Part-of: #1529 Signed-off-by: Sam James <sam@gentoo.org>
e12f6ac to
5aae622
Compare
Hiding the build/test output if there is just one merge job results in a bad package testing experience (for users who have --jobs enabled by default). Therefore, do not go in background mode if there is just one merge job and --quiet was not requested. Closes: https://bugs.gentoo.org/339579 Signed-off-by: Florian Schmaus <flow@gentoo.org>
5aae622 to
5535ca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.