This repository was archived by the owner on Oct 2, 2025. It is now read-only.
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jmoseley
force-pushed
the
codex/add-public-option-to-project-configuration
branch
from
c3728d3 to
5cf4ae1
Compare
jmoseley
changed the title
jmoseley
requested review from
EvanBoyle,
danfhernandez and
dereklegenzoff
and removed request for
EvanBoyle and
danfhernandez
| projectName: z.string(), | ||
| environmentName: z.string().optional(), | ||
| description: z.string().optional(), | ||
| publicWorkflows: z.boolean().optional(), |
Contributor
There was a problem hiding this comment.
I'd lean towards just calling this public. Spelling it out as publicWorkflows has better specificity but feels a bit clunky. Plus it would better align with the param in the CLI.
| projectName: z.string(), | ||
| environmentName: z.string().optional(), | ||
| description: z.string().optional(), | ||
| public: z.boolean().optional(), |
Contributor
There was a problem hiding this comment.
seems like there's a mismatch between here and the schema we use in the gensx package? public vs publicWorkflows
dereklegenzoff
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicWorkflowsoption in config--publicWorkflowsoption innewcommand--publicWorkflowsflag