Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Bug: Incorrect `rootDir` Handling in Configuration
The condition for using a provided rootDir incorrectly checks options.kind instead of the determined kind variable. If options.kind is undefined but kind defaults to "filesystem", a provided options.rootDir is ignored, and the default directory is used instead.
packages/gensx-storage/src/kv/kvClient.ts#L16-L20
gensx/packages/gensx-storage/src/kv/kvClient.ts
Lines 16 to 20 in 74db3c5
Bug: Expired Keys Included, Inefficient File Reads
The listKeys method incorrectly includes expired keys in its results. Although the get() method correctly deletes expired files, listKeys still adds the key to the list. Additionally, listKeys reads each file twice, which is inefficient and creates a race condition where the second read can fail if the file is deleted after the first read (e.g., by the initial get() call), causing the operation to error.
packages/gensx-storage/src/kv/filesystem.ts#L110-L126
gensx/packages/gensx-storage/src/kv/filesystem.ts
Lines 110 to 126 in 74db3c5
BugBot free trial expires on June 9, 2025
Your team has used $0.00 of the $50.00 spend limit so far. Team admins can manage spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Hey mate 👋. Thank you for opening this Pull Request 🤘. It is really awesome to see this contribution 🚀 🔎 When working with this project we are requesting to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted 🥶. 👇 Bellow you can find details about what failed: |
Summary
gensx-storageKVClientanduseKVhelpersTesting
pnpm lintpnpm test(fails: create-gensx#test)pnpm formathttps://chatgpt.com/codex/tasks/task_e_6841deb474f0832c81a09484e22d2581