[Feature] Change to nginx-unprivileged image for better kubernetes support#1922
[Feature] Change to nginx-unprivileged image for better kubernetes support#1922hsolberg wants to merge 4 commits intogchq:masterfrom
Conversation
Originally encountered a problem with the ChromeDriver version that's been addressed in d3adfc7 , expand to show the context if needed.UI Test fails with the error below. Seems a lot of pull-requests are facing the same issue. |
|
Have these tests been fixed? |
8fdc311 to
32dda5b
Compare
Seem to work now after rebasing. Looks like this commit addressed the issue -> d3adfc7 |
|
You might want to change the docker commandline in the readme so it shows forwarding to the new default ports of docker run -it -p 8080:8080 cyberchefand docker run -it -p 8080:8080 ghcr.io/gchq/cyberchef:latestAs per: https://hub.docker.com/r/nginxinc/nginx-unprivileged |
|
Hey, thanks so much for the PR. This will need to be linked to a major bump, due to the changing default port. I see no problems with the current implementation though. |
Hi! What's the next step here? Anything I need to do or are we waiting for the next major release to include this? |
Solves #1880
Not sure which image-repo you prefer to use, it's using Docker Hub in the pull-request (should be fine since its from a "Verified Publisher" and thus does not count towards the rate limit).
Alternative sources can be found here
Amazon ECR - https://gallery.ecr.aws/nginx/nginx-unprivileged
Docker Hub - https://hub.docker.com/r/nginxinc/nginx-unprivileged
GitHub Container Registry - https://github.com/nginxinc/docker-nginx-unprivileged/pkgs/container/nginx-unprivileged
Quay - https://quay.io/repository/nginx/nginx-unprivileged