Skip to content

feat: (DSO-2330) Update set-env action to support new convention#7

Merged
javiercm1410 merged 23 commits into
mainfrom
feat-DSO-2330-update-name-convetion-for-tags
Oct 2, 2025
Merged

feat: (DSO-2330) Update set-env action to support new convention#7
javiercm1410 merged 23 commits into
mainfrom
feat-DSO-2330-update-name-convetion-for-tags

Conversation

@javiercm1410

@javiercm1410 javiercm1410 commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Summary

Update action to support new convention


Note

Add package tag and FORCE_REF support to environment-detection action and introduce comprehensive CI tests covering tags, branches, invalid refs, and PR context.

  • Action (action.yml):
    • Add FORCE_REF override to simulate refs; enhance debug output and safe file writes.
    • Broaden version matching with robust regex; support standard vX.Y.Z/vX.Y.Z-uat.N and package refs <pkg>@X.Y.Z/<pkg>@X.Y.Z-uat.N (including scoped).
    • Refine branch/event handling (exact default-branch match); clearer errors and final ENV echo.
  • CI (.github/workflows/tests.yml):
    • Rename workflow/job and extend PR branches; fix CODE_OF_CONDUCT path.
    • Replace simple check with comprehensive tests:
      • Conventional prod/uat tags (v1.0.0, v1.0.0-uat.1).
      • Package prod/uat refs (@gbh-tech/internal-jobs@1.0.0, ...@1.0.0-uat.1).
      • Invalid tag expected failure.
      • Branch main and current PR context resolve to stage.
      • Verify ENVIRONMENT variable is set.

Written by Cursor Bugbot for commit 1768e21. This will update automatically on new commits. Configure here.

@javiercm1410 javiercm1410 self-assigned this Oct 1, 2025
cursor[bot]

This comment was marked as outdated.

@javiercm1410

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

Comment thread action.yml
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Co-authored-by: Angel Adames <9947992+angelmadames@users.noreply.github.com>
Comment thread .github/workflows/tests.yml Outdated
angelmadames
angelmadames previously approved these changes Oct 2, 2025
@javiercm1410 javiercm1410 force-pushed the feat-DSO-2330-update-name-convetion-for-tags branch from 1bd360f to f8b0c35 Compare October 2, 2025 19:22
@javiercm1410 javiercm1410 merged commit 57af1c3 into main Oct 2, 2025
2 checks passed
@javiercm1410 javiercm1410 deleted the feat-DSO-2330-update-name-convetion-for-tags branch October 2, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants