Skip to content

fix build with asio 1.36#25

Merged
mergify[bot] merged 2 commits intogbartyzel:rollingfrom
nim65s:asio
Apr 9, 2026
Merged

fix build with asio 1.36#25
mergify[bot] merged 2 commits intogbartyzel:rollingfrom
nim65s:asio

Conversation

@nim65s
Copy link
Copy Markdown
Contributor

@nim65s nim65s commented Apr 1, 2026

Hi,

This PR fix build with asio 1.36.

io_service has been deprecated for at least 9 years (ref. blame https://github.com/boostorg/asio/blame/995eeab56906ab0a1f614602aa0dee9ee88bf8cb/include/boost/asio/io_service.hpp), and removed in boostorg/asio@ec0908c
from_string has been deprecated for at least 9 years (ref blame https://github.com/boostorg/asio/blame/b60e92b13ef68dfbb9af180d76eae41d22e19356/include/boost/asio/ip/address.hpp), and removed in boostorg/asio@c0d1cfc

While here, remove a CMake v4 warning about CMake < 3.10

nim65s added 2 commits April 1, 2026 20:41
fix warning:
```
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.
```
@nim65s nim65s mentioned this pull request Apr 1, 2026
Copy link
Copy Markdown
Owner

@gbartyzel gbartyzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ;)

@gbartyzel
Copy link
Copy Markdown
Owner

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 9, 2026

Merge Queue Status

  • Entered queue2026-04-09 20:34 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-04-09 20:34 UTC · at a2770efe5d4ec3560fd35b4672a3b59d15c37d30

This pull request spent 11 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify bot added the queued label Apr 9, 2026
@mergify mergify bot merged commit 6dd0d08 into gbartyzel:rolling Apr 9, 2026
8 checks passed
@mergify mergify bot removed the queued label Apr 9, 2026
mergify bot added a commit that referenced this pull request Apr 9, 2026
Hi again,

this just backport #25 to humble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants