Remove unused gz/common/Profiler.hh include in Ogre2Scene.cc - #1314
Closed
j-rivero wants to merge 1 commit into
Closed
Remove unused gz/common/Profiler.hh include in Ogre2Scene.cc#1314j-rivero wants to merge 1 commit into
j-rivero wants to merge 1 commit into
Conversation
This header is not used in the file and is not part of the original PR #1302. It breaks the Bazel build since gz-common does not expose this header there. Generated-by: Claude Sonnet 5 Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Contributor
Author
|
The PR is not correct. The Profile header is IN use and was not part of the original #1302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
ogre2/src/Ogre2Scene.ccincludes<gz/common/Profiler.hh>but neveruses it. This header was not part of the original #1302 and breaks the
Bazel build, since gz-common's Bazel target does not expose it:
Reported by @luca-della-vedova on the gz-rendering10 backport (#1305):
https://github.com/gazebosim/gz-rendering/pull/1305/changes#r3519694401
The same dead include is also present in the two other open backports
of #1302 (#1306, #1307); fixes have been pushed to those PR branches
directly.
Checklist
Generated-by: Claude Sonnet 5